search

pop-os / gtk-theme

System76 Pop GTK+ Theme
GNU General Public License v3.0
787 stars 83 forks source link

Sync 3.38 #476

Closed isantop closed 4 years ago

isantop commented 4 years ago

Pulls in changes in the base theme from Adwaita 3.38

isantop commented 4 years ago

Note: Since the master branch of this repo currently only builds for groovy, the failed bionic build should not be a problem. It appears to be differences related to sassc

isantop commented 4 years ago

Testing should just be a factor of ensuring there are no apparent regressions in either the GTK or GNOME Shell themes.

jacobgkau commented 4 years ago

The only difference I've spotted so far is when opening icon grid folders, their titles are faded after the change. Before:

folder-title-before

After:

folder-title-after

That seems like it could be a regression. It looks like the color line was removed from the .folder-name-label class in _app-grid.scss. Looking upstream, I found a merge request where this issue was reported and fixed by adding color: $osd_fg_color; to the class (where it used to be color: rgba($osd_text_color, 0.8); in our theme before this PR, and didn't seem to be set upstream before that MR.)

isantop commented 4 years ago

I agree with that assessment. I'll update that.

jacobgkau commented 4 years ago

That fixed the label when viewing the folder. I am also seeing a regression when editing folder names, which was not fixed by that change. It only seems to affect the light theme. Before:

light-before-1

light-before-2

After:

light-c-after-1

light-c-after-2

It looks like the highlight color and text color when editing are being taken from the dark theme even when using the light theme.

isantop commented 4 years ago

Actually, it appears they were being taken from the non-editing mode. Since the entry is light-colored, the light text blended in.