search

pop-os / gtk-theme

System76 Pop GTK+ Theme
GNU General Public License v3.0
782 stars 81 forks source link

Support for Hdy #482

Closed isantop closed 3 years ago

isantop commented 3 years ago

This pulls in the upstream LibHandy theming and makes the requisite tweaks to make everything work in Pop.

isantop commented 3 years ago

For testing, please install the libhandy-1-dev package and run handy-1-demo to verify that widgets in the demo look correct and don't have visual glitches. Please be aware that the window is size-sensitive and may require making the window narrow or wide to check full compatibility.

isantop commented 3 years ago

@jacobgkau as of b387f81 the corner radius of windows should now match the top border of non-hdyWindow widgets. The bottom corners are still rounded (because this is a feature specified by LibHandy), however the radius on the bottom matches the top radius.

jacobgkau commented 3 years ago

The borders look good. The only other thing I'm noticing is that the action widgets on list rows are a little difficult to see when not hovering on them. Before the change:

Screenshot from 2020-11-03 16-22-11

After the change:

Screenshot from 2020-11-03 16-21-22

(The difference is also present in the light theme.) Comparing with Adwaita, it also has buttons that aren't very distinguished from the rest of the row:

Screenshot from 2020-11-03 16-18-45

Is this something we'd adjust, or is the current look expected?

isantop commented 3 years ago

I'd say for now, this should be considered expected. We aren't changing very much from Adwaita, and that's an intentional decision.

ids1024 commented 3 years ago

Haven't compared with the previous version, but this inconsistency definitely doesn't look right:

> dpkg --listfiles pop-gtk-theme | grep '/usr/share/themes/.*/gtk-3'
/usr/share/themes/Pop/gtk-3.0
/usr/share/themes/Pop/gtk-3.0/gtk-dark.css
/usr/share/themes/Pop/gtk-3.0/gtk.css
/usr/share/themes/Pop/gtk-3.0/gtk.gresource
/usr/share/themes/Pop-dark/gtk-3.0
/usr/share/themes/Pop-dark/gtk-3.20
/usr/share/themes/Pop-dark/gtk-3.0/gtk.css
/usr/share/themes/Pop-dark/gtk-3.0/gtk.gresource
/usr/share/themes/Pop-dark/gtk-3.20/gtk.css
/usr/share/themes/Pop-dark/gtk-3.20/gtk.gresource

So there is a Pop-dark/gtk-3.20, but not Pop/gtk-3.20...

isantop commented 3 years ago

I think that's due to the symlink item noted. Unless we see any usability issues from that, I think it would be better to merge this PR and fix the symlink question in a different one.

isantop commented 3 years ago

Tracked in #484