search

pop-os / gtk-theme

System76 Pop GTK+ Theme
GNU General Public License v3.0
781 stars 80 forks source link

Epiphany header-bar font colors are too dark for saved web apps. #483

Closed bryanpaget closed 2 years ago

bryanpaget commented 3 years ago

Describe the problem:

The header-bar font used by Epiphany's installed web apps is too dark.

image

Steps to reproduce:

  1. Create web app with Epiphany by opening the hamburger menu and select "Install Site as Web Application..."
  2. Open the app.
  3. Observe dark title text.

Distribution:

Pop version:

cat /etc/os-release | grep -i pretty_name

Installed: 5.3.0~1603307552~20.10~a5e0cc9

flatpak info org.gtk.Gtk3theme.Pop

Pop Gtk theme - Pop Gtk theme used by System76

ID: org.gtk.Gtk3theme.Pop
Ref: runtime/org.gtk.Gtk3theme.Pop/x86_64/3.22
Arch: x86_64
Branch: 3.22
Origin: flathub
Collection: org.flathub.Stable
Installation: system

Installed: 1.6 MB

Commit: bf0014cc176fe2a66eb69045bc3ed80663e09240dda1db97b5394ba3a501bea3
Parent: 6154d9636034f0866dc7a2a08815931c641298ccfe1f5dd180875f4a4cb20f03
Subject: Fix build issue (9d2c3d49)
Date: 2019-10-22 21:52:03 +0000

Epiphany Version

epiphany-browser --version

Web 3.38.1
bryanpaget commented 3 years ago

The dark version of the pop theme does not have this issue.

isantop commented 3 years ago

This problem is occurring because the CSS within Epiphany is setting the theme FG Color as the title text for Web Apps.

https://gitlab.gnome.org/GNOME/epiphany/-/blob/master/src/resources/themes/shared.css#L11

It will require patching in Epiphany to fix it, or using the Dark theme with Epiphany.

isantop commented 3 years ago

Merge Request opened upstream: https://gitlab.gnome.org/GNOME/epiphany/-/merge_requests/857

isantop commented 3 years ago

Upstream MR was merged. New versions should include the specified fix.

isantop commented 2 years ago

Closing this issue for now because the upstream MR was added.