search

pop-os / gtk-theme

System76 Pop GTK+ Theme
GNU General Public License v3.0
787 stars 83 forks source link

Define text_view_bg #506

Closed jacobgkau closed 3 years ago

jacobgkau commented 3 years ago

Fixes https://github.com/pop-os/gtk-theme/issues/505.

Regression testing should check that this doesn't change the background colors of any other text widgets, and doesn't affect the terminal theming in Pop!_OS.

jacobgkau commented 3 years ago

Looking at Adwaita, they darken the base_color by 6% in the dark theme: https://gitlab.gnome.org/GNOME/gtk/-/blob/cc64dbafbc8158d5116bf2afe2d422da48b77137/gtk/theme/Adwaita/_colors-public.scss#L118

I was just copying base_color since that's what GNOME Terminal was falling back to before it broke, but it might be better to more closely copy what Adwaita's doing here.

jacobgkau commented 3 years ago

I've updated to mirror Adwaita's darkening behavior, since it looks like other parts of this file are following Adwaita too. The before/after can be seen in the screenshots in https://github.com/pop-os/gtk-theme/issues/505.