search

pop-os / gtk-theme

System76 Pop GTK+ Theme
GNU General Public License v3.0
779 stars 80 forks source link

fix(apps): Tweaks to improve the Firefox tab line color in Groovy #514

Closed isantop closed 3 years ago

isantop commented 3 years ago

This unfortunately affects all of Firefox, so we also darken the color so enable it to have somewhat acceptable contrast. It is confined to Firefox though.

DO NOT DELETE THIS BRANCH AFTER MERGING, as the same branch is going into #513 and #515

jacobgkau commented 3 years ago

This gets the accent colors back. Contrast seems like it might be a little too low in the dark theme:

Screenshot from 2021-04-20 16-04-10

Screenshot from 2021-04-20 16-04-58

GNOME Contrast puts it around a 1.6:1 contrast ratio, where the light theme's at a more tolerable 3.3:1. Can contrast be improved further in the dark theme?

jacobgkau commented 3 years ago

Our GNOME Terminal theme uses the light theme's highlight background (#48b9c7) against a white foreground color for highlighted text, and the web content portion of Firefox already uses the light theme instead of the dark theme, so if we were to use the light theme's highlight background within Firefox even in the dark theme, that would not be unprecedented.

The other alternative for Pop!_OS would be to ship a default CSS file for Firefox to override the highlight and/or text colors, instead of relying only on the GTK theme, since Firefox's own theming seems to allow more control than what it reads from the GTK theme.

isantop commented 3 years ago

@jacobgkau I set the background color to #48b9c7 as you suggested. The contrast is a bit iffy, but that was definitely not an okay contrast in the dark theme with the previous color.