search

pop-os / gtk-theme

System76 Pop GTK+ Theme
GNU General Public License v3.0
779 stars 80 forks source link

Pop Shop with Pop-dark theme update button unreadable under installed/updates tab #516

Closed Scotty-Trees closed 3 years ago

Scotty-Trees commented 3 years ago

Greetings lovely people,

When using Pop! Shop and selecting/checking the change-log for updates,when going back to the Installed tab, the previous selection is highlighted, but the update button becomes unreadable in all black

Screenshot from 2021-04-27 20-14-30

Steps to reproduce:

  1. Open Pop! Shop. Make sure to be using the Pop-dark theme.
  2. Click on the Installed tab at the top
  3. For this to show the theme issue, there needs to an an update available either by the system or a flatpak because there needs to be a visible update button. If everything is up to date, then this issue can't be reproduced because the update button won't show.
  4. IF updates are showing, then click on Operating System Updates or if a flatpak needs an update, click that too, it'll reproduce the same issue as well.
  5. After clicking the Operating System Updates and reading the change-log of what's new, press the back button (installed tab top left corner), and when it takes you back to the main Installed tab, the Operating System Updates section is highlighted since it was last selected which is fine. However, now in this highlighted section the update button on the right turns to all black and becomes unreadable. I've tested this also under the Adwaita dark theme and Ubuntu's Yaru-dark theme and those do not present the same unreadable issue, so they may be worth looking into their code for possible implementations to correct this minor issue. Merely a suggestion of course, but I hope this helps.

I think in this case the font could be white text, or perhaps change the color of the button when it is highlighted like this in this state? I'm not a CSS person so I wish I could be of more help, but that was just something I noticed that could use a tweak. I understand if this is a low priority, but I hope it's something that is a quick and easy fix for y'all because Pop-dark is hands down my favorite GTK dark theme I've used in years. Keep up the great work!

Distribution: Pop!_OS 20.04 LTS Pop version: 5.2.0~1599689740~20.04~11b9d22 flatpak info org.gtk.Gtk3theme.Pop-dark:

scott@pop-os:~$ flatpak info org.gtk.Gtk3theme.Pop-dark

Pop Gtk theme - Pop Gtk theme used by System76

          ID: org.gtk.Gtk3theme.Pop-dark
         Ref: runtime/org.gtk.Gtk3theme.Pop-dark/x86_64/3.22
        Arch: x86_64
      Branch: 3.22
      Origin: flathub
  Collection: org.flathub.Stable
Installation: user
   Installed: 1.1 MB

      Commit: cb13fccb1a397f172bbfa27e7f9b6e1b4d16b5a316768f67f3ba178e14f1ad6a
      Parent: 01db4ce9aee609219f7c47db545f445cdaa0bb9a4c6088ca3b09e9cd1e747227
     Subject: add flathub.json (6f5d1226)
        Date: 2020-11-17 21:02:13 +0000