pop-os / gtk-theme

System76 Pop GTK+ Theme
GNU General Public License v3.0
788 stars 83 forks source link

`README.md`: Add guide on user local install and document build dependencies for Fedora #526

Closed mbana closed 2 years ago

mbana commented 3 years ago
jacobgkau commented 3 years ago

@mbana Please make the change requested in the unresolved review thread. (I still do not have access to push to this branch.)

mbana commented 3 years ago

@mbana Please make the change requested in the unresolved review thread. (I still do not have access to push to this branch.)

Hi, I want to delete my fork. Can you please take a look at the changes as and when you can please.

jacobgkau commented 3 years ago

The commands look fine now. Regarding the wording:

NB: We do not guarantee that we will keep the set of commands below up to date nor support it. That said, to install dependencies on Fedora:

There is only one "unsupported" Fedora command present, but this wording makes it sound like the rest of the readme is unsupported and/or applies only to Fedora. I think a "To install dependencies on Fedora:" would be sufficient, and if the instructions become out-of-date in the future, Fedora users are welcome to submit further PRs to update them. Not sure if that would address what @isantop was bringing up earlier.