pop-os / gtk-theme

System76 Pop GTK+ Theme
GNU General Public License v3.0
779 stars 80 forks source link

Pop and Pop-Dark both give a dark shell theme #531

Closed KarkanAlzwayed closed 2 years ago

KarkanAlzwayed commented 2 years ago

Describe the problem: Both Pop and Pop dark give the shell a dark theme (the panel drop down menu and right click on the desktop are both dark, for example)

Steps to reproduce: Install through git clone on Fedora

Distribution: Fedora 34 (Workstation Edition)

isantop commented 2 years ago

The shell theme is switched separately from the main GTK Theme and requires using the User Themes extension.

KarkanAlzwayed commented 2 years ago

@isantop there isn't a "pop" or "pop light" choice for the shell in gnome tweaks, with the user themes installed and enabled.

shalzz commented 2 years ago

This is still an issue. With the User shell themes extension installed selecting "Pop" or "Pop-dark" does not make any difference. They both result in a dark shell theme. Looking at the css they are essentially the same:

$ diff /usr/share/themes/Pop/gnome-shell/gnome-shell.css /usr/share/themes/Pop-dark/gnome-shell/gnome-shell.css
2213a2214,2243
> 
> /* Pop_OS COSMIC Widget styling. */
> /* Pop_OS COSMIC Dock styling, append !important to any changed rules */
> .cosmic-dock #dock {
>   border-radius: 12px 12px 12px 12px !important;
>   border: 1px solid rgba(255, 255, 255, 0.16);
>   background-color: #33302F;
>   margin: 4px !important; }
> 
> .cosmic-dock.extended #dock {
>   border-radius: 0px !important;
>   margin: 0 !important; }
> 
> .cosmic-dock.extended.side #dock {
>   border-top-width: 0 !important;
>   border-bottom-width: 0 !important; }
> 
> .cosmic-dock.extended.side.left #dock {
>   border-left-width: 0 !important; }
> 
> .cosmic-dock.extended.side.right #dock {
>   border-right-width: 0 !important; }
> 
> .cosmic-dock.extended.bottom #dock {
>   border-bottom-width: 0 !important;
>   border-left-width: 0 !important;
>   border-right-width: 0 !important; }
> 
> .cosmic-dock .app-well-app:hover .overview-icon, .cosmic-dock .app-well-app:focus .overview-icon, .cosmic-dock .app-well-app:selected .overview-icon {
>   border-radius: 11px; }

Tried on Arch with the official pop-gtk-theme pacakge