search

pop-os / gtk-theme

System76 Pop GTK+ Theme
GNU General Public License v3.0
779 stars 80 forks source link

Missing elementary color palette from OS 6 Odin #541

Closed cassidyjames closed 2 years ago

cassidyjames commented 2 years ago

Describe the problem:

It looks like the current Pop theme doesn't include the updated color palette variables from the elementary OS 6 Odin stylesheet. As a result, upstream versions of elementary apps like AppCenter and potentially installer and Sideload and third-party apps targeting elementary OS will look broken.

Screenshot from 2021-09-16 11-43-11@2x

Screenshot from 2021-09-16 11-43-03@2x

Steps to reproduce:

  1. Install AppCenter from upstream
  2. See the missing colors

Distribution:

Tested on elementary OS 6 Odin

Pop version:

Pop theme from master

cassidyjames commented 2 years ago

Specifically, it looks like accent shades are missing, e.g.:

https://github.com/elementary/stylesheet/blob/983b83f6858a31af3bc2b7cd0f33a572dd8ec011/src/variants/orange.scss#L22-L29

cassidyjames commented 2 years ago

Ah, the specific issue with AppCenter is actually missing text_color and accent_color. It would be good to support the full accent palette but I'll get a minimal PR in to fix this specific case at least.

isantop commented 2 years ago

Closing as the relevant PR was merged successfully