search

pop-os / gtk-theme

System76 Pop GTK+ Theme
GNU General Public License v3.0
779 stars 80 forks source link

flatpak Polari not working with flatpak Pop theme #549

Closed Yuri6037 closed 2 years ago

Yuri6037 commented 2 years ago

Describe the problem: Today I got an update for Polari IRC client. I'm using the flatpak version and I noticed 3 issues:

I report this here only for the theme problem, I will report the 2 other problems to GNOME Polari directly.

Steps to reproduce:

  1. Install flatpak version of Polari

Distribution: Pop!_OS 21.04

Pop version:

isantop commented 2 years ago

This is due to limitations with LibAdwaita, which prevents loading the system theme. The issue should be filed against LibAdwaita, here: https://gitlab.gnome.org/GNOME/libadwaita/-/issues

Yuri6037 commented 2 years ago

Thank you but I've just filled that issue on libadwait who told me that this is intended behavior. Is there any way you provide a patched version of libadwaita which fixes this bug on Pop OS? It's really annoying to see apps using totally different theming on this OS.

BrainBlasted commented 2 years ago

Please do not redirect issues to libadwaita for that. The stylesheet handling is intentional :)

Yuri6037 commented 2 years ago

Apparently this is not libadwaita problem:

Quote from https://gitlab.gnome.org/GNOME/libadwaita/-/issues/277: "Also, Polari isn't currently using libadwaita. Your issue is likely due to there being no GTK4 extension for the Pop theme on Flathub."

Do you confirm no extension for Gtk4 are available on the flathub?

EDIT: Also according to them, as a distribution provider you should be providing your own lib to fix this problem.

EDIT2: According to Polari devs: https://gitlab.gnome.org/GNOME/polari/-/issues/193 Polari does not use libadwaita so @isantop is wrong. This is a problem with Pop OS GTK theme!

EDIT3: You should re-open the issue.

isantop commented 2 years ago

Please do not redirect issues to libadwaita for that. The stylesheet handling is intentional :)

@brainblasted Intentional or not, if a user of my software projects is experiencing an issue that is beyond my capability to fix, I am entitled to direct them to the appropriate place to report said issue.

Do you confirm no extension for Gtk4 are available on the flathub?

If Polari isn't currently using LibAdwaita, then that is correct. GTK4 extensions to the theme are expected to be released next month.

BrainBlasted commented 2 years ago

EDIT: Also according to them, as a distribution provider you should be providing your own lib to fix this problem.

That's a misinterpretation of my statement. What I meant was different desktop environments that want to ship GTK (not GNOME) apps can work together and create one with theming support as they see fit. I did not mean that distros should be replacing/patching libadwaita for GNOME apps.

Intentional or not, if a user of my software projects is experiencing an issue that is beyond my capability to fix, I am entitled to direct them to the appropriate place to report said issue.

I understand that, but in this case it's not an issue upstream, and thus not appropriate for us. In the future, you could perhaps say that changing the stylesheet is not supported for GNOME applications and that it's intended behavior.

jackpot51 commented 2 years ago

@isantop please update the flatpak theme to support GTK4 when you can.

jackpot51 commented 2 years ago

It looks like work was already started but not finished: https://github.com/flathub/org.gtk.Gtk3theme.Pop/pull/7

jackpot51 commented 2 years ago

Closed, since this has nothing to do with Polari, and opened a new more specific issue: https://github.com/pop-os/gtk-theme/issues/553

isantop commented 2 years ago

Yep, was looking at several things wrt to that. It's good to know that Polari should support the theme correctly, as every other app I tested using Gtk4 was also using Libadwaita

jackpot51 commented 2 years ago

For the future instances of bugs like this from applications that actually do use libadwaita, just close and wontfix. Do not direct them to open an issue on libadwaita or the application itself.