search

pop-os / gtk-theme

System76 Pop GTK+ Theme
GNU General Public License v3.0
788 stars 83 forks source link

Shell Entries have poor contrast with selected text in Dark Mode. #554

Open isantop opened 3 years ago

isantop commented 3 years ago

When the Shell is using the dark theme, StEntry widgets have very poor selected text contrast due to a bug in the way CSS is processed in the Shell code itself. Specifically, it seems that it ignores the selected-color property, which is supposed to set the text color for selected text. Instead if falls back to the standard Entry text color, which is far too light to have good contrast.

Shell bug: pop-os/gnome-shell#78

cat-zer0 commented 2 years ago

Actually, the font should be white in dark mode. I solve this issue by activating the GNOME shell extension "User Themes". Then, I set in the setting of this extensions the shell theme from "default" to "Pop dark". After the activation of this extension, you can set the shell theme under "Appearance" in GNOME Tweaks too. User Themes can be activated in Extensions (gnome-shell-extensions) or with the browser addon on extensons.gnome.org.

isantop commented 2 years ago

Installing User Themes is not a viable solution to this issue from our end. The Shell should be rendering the selected text using the styling which was provided, however that styling is ignored. That's what makes this issue an "Upstream" issue (bug in Shell, as opposed to in the theme itself