search

pop-os / gtk-theme

System76 Pop GTK+ Theme
GNU General Public License v3.0
782 stars 81 forks source link

fix(shell): fix screenshot UI contrast #575

Closed isantop closed 2 years ago

isantop commented 2 years ago

The active and hovered buttons in the new screenshot UI were very low-contrast; this improves the contrast of the icons and button backgrounds to be easier to see against a wide variety of layers underneath.

jacobgkau commented 2 years ago

Before (Selection active, Window being hovered over): Screenshot from 2022-04-05 12-35-52

After: Screenshot from 2022-04-05 12-36-57

According to GNOME Contrast, the top of the active Selection button used to have a contrast of 7.1:1, and now has a contrast of 7.5:1 (higher). The hovered Window button used to have a contrast of 8.4:1, and now has a contrast of 7.6:1 (lower). The button to toggle to a video used to have a contrast of 10.4:1, and now has a contrast of 1.3:1 (lower).

Hovering over the button to switch to video also seems to have gotten significantly worse. Before:

Screenshot from 2022-04-05 12-48-30

After:

Screenshot from 2022-04-05 12-47-59

isantop commented 2 years ago

@jacobgkau Thanks for pointing those out. Looks like the dark theme still needs some work.

Please remember that all Theme PRs need to be tested in both the dark and light themes.

isantop commented 2 years ago

@jacobgkau This is now ready for review again