search

pop-os / icon-theme

System76 Pop icon theme for Linux
Creative Commons Attribution Share Alike 4.0 International
203 stars 27 forks source link

Selection checked #49

Closed isantop closed 5 years ago

isantop commented 5 years ago

Adds a selection-checked-symbolic icon. Required for pop-os/installer#199

isantop commented 5 years ago

@pop-os/quality-assurance For QA testing this, please ensure that nothing breaks on upgrade, and that after upgrading the path /usr/share/icons/Pop/scalable/actions/selection-checked-symbolic.svg exists.

Thanks

brs17 commented 5 years ago

~My hesitation here is how this would look on 18.04 where the highlight color is blue, that may contrast a lot with this grey checkmark (where as currently the checkmark in 18.04 is white).~

EDIT: The hightlight color is blue in both 19.10 and 18.04, I am not sure what that would look like (contrast wise).

@mmstick Do you think you could get a pr ready as detailed here: https://github.com/pop-os/installer/issues/199#issuecomment-540067570 ? That would probably be the best way to test this out and come to a final conclusion.

isantop commented 5 years ago

@brs17 Symbolic icons are colored dynamically by GTK. This will contrast no matter what theme is present because the theme can set the color dynamically.

leviport commented 5 years ago

I might need a hand going over this one tomorrow morning. From a live disk, I applied the patch, installed updates, restarted Gnome, and restarted the installer, but I'm still seeing the same icon as before. I'm probably missing something, but I'm not quite sure what it is.

selection-checked-seems-same

jackpot51 commented 5 years ago

@leviport it appears that the pop-installer was not built, I am working on that now but need this to be in proposed to do correct ISO testing