pop-os / icon-theme

System76 Pop icon theme for Linux
Creative Commons Attribution Share Alike 4.0 International
202 stars 27 forks source link

"Solaar" System Tray Battery Icon broken only in Pop Icon Theme #85

Open BaronKrause opened 3 years ago

BaronKrause commented 3 years ago

Ever since the new Pop Icon theme that replaced the older Papirus based one, the Logitech mouse software Solaar's Battery icon in the system tray always uses the default "Copper Top" looking 16x16 png for all battery/charging states. It uses the icon themes own battery icons, and can switch between the old style and the newer symbolic icons with a command switch.

It works as expected with the system tray in every other theme I have downloaded and tested, but it is always busted in Pop's. I cant for the life of me figure out what is different about the theme that is causing the issue and the developer isn't sure either since it works everywhere else.

Anyone have any ideas? Is there something different with how the Pop theme handles the battery icons maybe?

Thank you!

isantop commented 3 years ago

Thanks for your report! Can you post a screenshot showing the breakage that you're seeing with the Pop Icons?

BaronKrause commented 3 years ago

Thanks for your report! Can you post a screenshot showing the breakage that you're seeing with the Pop Icons?

Sure! But now that I tested it again it appeared that the problem has been mostly fixed. You can launch the application using with normal non symbolic icons for both the tray and in application (default), with symbolic icons, or with the generic application icon as the tray icon (using non symbolic icons in app).

Ive been running it with the default app icon in the tray since I made this issue since it looked better than what was a old low battery icon.

Ive attached a picture of the application running with both normal and symbolic icons. The symbolic seems to work flawlessly, the non symbolic seems to still use the "copper top" icon in the application (this is what also showed in the system tray for both default and symbolic in the past under this theme), but it doesn't seem like a big deal since the symbolic ones are what mach the theme better.

Screenshot from 2021-10-20 11-57-04 Screenshot from 2021-10-20 11-57-43

Thanks for looking!

isantop commented 3 years ago

Ah, I think I see what's going on. Should be a pretty simple fix.

BaronKrause commented 2 years ago

Ah, I think I see what's going on. Should be a pretty simple fix.

I just noticed that the fixed battery icon for Solaar has regressed in the Pop theme back to the old unchanging Copper top icon. Same as before it is only broken in the top panel, not in the apps menu and shows that same icon regardless if Solaar is set to show Symbolic or standard icons. And like before it shows this same icon for all battery levels. Sometime over the past week or so a Pop update must of reverted whatever change fixed it.

Screenshot from 2021-12-03 21-23-45