search

pop-os / icon-theme

System76 Pop icon theme for Linux
Creative Commons Attribution Share Alike 4.0 International
203 stars 27 forks source link

Meld Icons doesn't look good with pop Icon theme #87

Closed stutzzzz closed 2 years ago

stutzzzz commented 3 years ago

Describe the problem: Meld Icons doesn't look right with PoP Icon Theme I think these icons are for light not dark themes

Steps to reproduce:

  1. Open Meld

Distribution: PRETTY_NAME="Pop!_OS 21.04"

Pop version: Installed: 2.1.0~1626456130~21.04~8e5d8ca

image using default gnome icons image

stutzzzz commented 3 years ago

I think I found the arrow icons looking for the Doc Icon Using Icon Browser it appears to be go-previous,next,down,up image

isantop commented 3 years ago

Thanks for the report! I looks like Meld is not requesting symbolic icons, which prevents Gtk from re-coloring the Icons dynamically to match the theme. Unfortunately, this issue cannot be fixed in the icon theme, because modifying the icons to have good contrast in the dark theme makes them invisible in the light theme (and vice-versa).

stutzzzz commented 3 years ago

it appears that flatpak version doesn't have as big of an issue compared to the deb. image looks like its only the arrow icons for previous and next change image

jacobgkau commented 3 years ago

modifying the icons to have good contrast in the dark theme makes them invisible in the light theme (and vice-versa).

Given that the dark theme is currently the default, would it make sense to prioritize that one?

Looking at Adwaita's icon theme, they're using colors that are visible in both the light and dark theme (but have more contrast in the dark theme, even though they default to light.)

isantop commented 2 years ago

Should be improved as of #99 , please feel free to reopen if contrast issues persist