search

pop-os / icon-theme

System76 Pop icon theme for Linux
Creative Commons Attribution Share Alike 4.0 International
203 stars 27 forks source link

Provide more granular battery charge icons #88

Closed clemans closed 3 years ago

clemans commented 3 years ago

Distribution (run cat /etc/os-release):

NAME="Pop!_OS" VERSION="21.04" ID=pop ID_LIKE="ubuntu debian" PRETTY_NAME="Pop!_OS 21.04" VERSION_ID="21.04" HOME_URL="https://pop.system76.com" SUPPORT_URL="https://support.system76.com" BUG_REPORT_URL="https://github.com/pop-os/pop/issues" PRIVACY_POLICY_URL="https://system76.com/privacy" VERSION_CODENAME=hirsute UBUNTU_CODENAME=hirsute LOGO=distributor-logo-pop-os

Related Application and/or Package Version (run apt policy $PACKAGE NAME):

gnome-shell-extension-system76-power: Installed: 2.0.1~1622647103~21.04~fc4aca1 Candidate: 2.0.1~1622647103~21.04~fc4aca1 Version table: *** 2.0.1~1622647103~21.04~fc4aca1 1001 1001 http://ppa.launchpad.net/system76/pop/ubuntu hirsute/main amd64 Packages 1001 http://ppa.launchpad.net/system76/pop/ubuntu hirsute/main i386 Packages 100 /var/lib/dpkg/status

Issue/Bug Description:

The battery icon shows an inaccurate reading battery life remaining. For example, my battery life will be at 99% but the icon shows 65%. This started earlier in 20.04. I completely reinstalled the operating system (deleted partition, reinstalled to newest pop_os) and the same battery reading issue remains. Example below:

Steps to reproduce (if you know):

  1. Charge to 100%
  2. Confirm that the battery icon in the top-right of the screen shows a visual misrepresentation of this number
  3. ???
  4. profit

Expected behavior:

  1. Charge to 100%
  2. Confirm that the battery icon in the top-right of the screen shows a visual proper representation of this number
  3. ???
  4. profit

Other Notes: Example: image

jacobgkau commented 3 years ago

That looks like the battery-good-charging icon, which is one step below battery-full-charging: https://github.com/pop-os/icon-theme/blob/master/Pop-Dark/24x24/panel/battery-good-charging.svg

All of the icons are located here: https://github.com/pop-os/icon-theme/tree/master/Pop-Dark/24x24/panel

I'm not sure there's anything wrong here, is this a feature request for more fine-grained battery icons?

clemans commented 3 years ago

I suppose it is a feature request if there are only three modes of battery life. When first using my Lemur Pro, the battery icon seemed different and expressed better detailed percentages.

jacobgkau commented 3 years ago

The only change to battery icons that I'm aware of would have been when the battery icon fix extension was removed: https://github.com/pop-os/session/pull/31 However, that extension doesn't contain any icons, so I don't see how it would have provided further levels.

This doesn't seem related to system76-power, so I'm going to transfer this issue to the icon-theme repository for now. It may need to be transferred again to gnome-shell or something else, though.

Looking around, there have been GNOME Shell extensions to make the battery indicator more precise, although their readme pages indicate that default GNOME Shell should have this already. Looking at issues in upstream Adwaita and GNOME Shell, it looks like we might be able to drop in new icons at 10% charge levels and have GNOME Shell display them.

clemans commented 3 years ago

Thanks, @jacobgkau for this information and willingness to help me steer this request in the right direction. Cheers.