Set mount after closing menu, & disallow BIOS systems to set /boot/efi

pop-os / installer

Installer for Pop!_OS & other Linux-based OSes

https://system76.com/pop

GNU General Public License v3.0

26 stars 16 forks source link

Closed mmstick closed 6 years ago

mmstick commented 6 years ago

This will:

Prevent the user from setting /boot/efi as a mount when in a BIOS environment.
Fix custom mount fields from overriding set mounts by only setting mounts after closing the menu

brs17 commented 6 years ago

[x] Prevent the user from setting /boot/efi as a mount when in a BIOS environment.
[x] Fix custom mount fields from overriding set mounts by only setting mounts after closing the menu

brs17 commented 6 years ago

When trying to use 2 partitions as "Custom", the second Custom will wipe the Use partition flag from the first one.

I am also thinking we should interpret a Custom mount of / as Root. (Not allow two root partitions)

mmstick commented 6 years ago

@brs17 I think those issues are fixed now.

brs17 commented 6 years ago

A "custom" mounting point of / should (after that popup message is dismissed) change to the root mounting point.

mmstick commented 6 years ago

Now working on this.

brs17 commented 6 years ago

Looking better, now once the root partition has changed, the option for mount point should be a blank custom option