search

pop-os / installer

Installer for Pop!_OS & other Linux-based OSes
https://system76.com/pop
GNU General Public License v3.0
26 stars 16 forks source link

Only allow an EFI install if the EFI partition is on a GPT table #161

Closed mmstick closed 6 years ago

mmstick commented 6 years ago

Requires https://github.com/pop-os/distinst/pull/140

brs17 commented 6 years ago

@mmstick Why don't we use the same emit_error as we do later in the install process, whereas now we're just running on_error? Or is that the same thing?

mmstick commented 6 years ago

@brs17 It's the same thing. When the UI receives the on_error callback, it runs its own on_error callback to switch over to the error view in advance. I've added a change in the installer that will ensure that it's on the error view when the install completes, in the event that the installer did not use that callback.

I can get the installer to handle that callback better in the script-to-rust PR.