search

pop-os / installer

Installer for Pop!_OS & other Linux-based OSes
https://system76.com/pop
GNU General Public License v3.0
26 stars 16 forks source link

Update installer help on EFI partition size #175

Closed thomas-zimmerman closed 5 years ago

thomas-zimmerman commented 5 years ago

Distribution (run cat /etc/os-release): 18.04, 18.10

Related Application and/or Package Version (run apt policy $PACKAGE NAME): installer

Issue/Bug Description: screenshot from 2019-01-21 19-34-57 EFI partition was created with 256MiB in size, installer states 256MiB is minimum but enforces a 500MiB minimum

Steps to reproduce (if you know): run installer

Expected behavior: installer help text matches enforced minimums

Other Notes:

mmstick commented 5 years ago

Seems the installer has this set:

const uint64 REQUIRED_EFI_SECTORS = 524288;

Where 524288 / 2 / 1024 does indeed equal 256 MiB, so the text is still valid.

It's likely that their partition was a few sectors shorter than the minimum requirement.

Though it's still better to recommend 500 MiB, since that's what a default install uses.