search

pop-os / installer

Installer for Pop!_OS & other Linux-based OSes
https://system76.com/pop
GNU General Public License v3.0
26 stars 15 forks source link

standardize keyboard behavior #252

Closed 13r0ck closed 2 years ago

13r0ck commented 2 years ago

Like #251, but for the install type selection pages Closes #249

Screenshot from 2021-12-17 23-34-38

jacobgkau commented 2 years ago

Rebased on master.

jacobgkau commented 2 years ago

Fixes https://github.com/pop-os/installer/issues/249. Navigating the installation type page solely with the keyboard now requires pressing Spacebar to select an option followed by Enter to proceed, the same as on the Disks page.

It does look like the decryption page needs a similar fix: decrypt If this PR is trying to standardize, can we address that at the same time?

13r0ck commented 2 years ago

Ya I can do that in this PR too

jacobgkau commented 2 years ago

This is working perfectly in a USB live disk.

In Recovery mode, on the "Refresh or Install" page, the Back button is focused by default instead of the first item in the list (which would be Refresh Install). This means pressing Enter repeatedly will end up going between two pages:

Peek 2022-02-01 23-54

Can we get the list focused (not selected, just focused) on this page by default so pressing Enter does nothing until the Spacebar is pressed to select something? That would match the live disk's behavior.

13r0ck commented 2 years ago

Yep I'll start on that

13r0ck commented 2 years ago

I fixed focus there, and on a clean install, the first disk is now focused rather than "cancel install"