pop-os / iso

Pop!_OS ISO production
Other
499 stars 65 forks source link

Live branches #318

Closed 13r0ck closed 1 year ago

13r0ck commented 1 year ago

This allows adding branches to the live build environment.

Requires that https://github.com/pop-os/repolib/pull/68 is merged and released first

ids1024 commented 1 year ago

It's great to have an easy way to build an ISO with staging packages. This has been an issue in the past.

13r0ck commented 1 year ago

This is now ready for review again. I am splitting this off from metapackage-reorg testing. This PR is now exclusively for adding any staging branch to an iso.

https://github.com/pop-os/iso/pull/321 will be for testing the metapackage reorg in a live environement

n3m0-22 commented 1 year ago

When running this with branches added to 22.04.mk I run into the following error. I believe it is caused by apt-manage not being prompted for a password.

Processing triggers for dbus (1.12.20-2ubuntu4) ...
+ for branch in $STAGING_BRANCHES
+ echo 'Adding preference for '\''metapackage-reorg'\'''
Adding preference for 'metapackage-reorg'
+ apt-manage add popdev:metapackage-reorg -y
Fetching repository information...
Traceback (most recent call last):
  File "/usr/bin/apt-manage", line 33, in <module>
    sys.exit(load_entry_point('repolib==2.2.1', 'console_scripts', 'apt-manage')())
  File "/usr/lib/python3/dist-packages/repolib/command/bin.py", line 91, in apt_manage
    result = command.run()
  File "/usr/lib/python3/dist-packages/repolib/command/add.py", line 267, in run
    util.dbus_quit()
  File "/usr/lib/python3/dist-packages/repolib/util.py", line 261, in dbus_quit
    bus = dbus.SystemBus()
  File "/usr/lib/python3/dist-packages/dbus/_dbus.py", line 195, in __new__
    return Bus.__new__(cls, Bus.TYPE_SYSTEM, mainloop=mainloop,
  File "/usr/lib/python3/dist-packages/dbus/_dbus.py", line 102, in __new__
    bus = BusConnection.__new__(subclass, bus_type, mainloop=mainloop)
  File "/usr/lib/python3/dist-packages/dbus/bus.py", line 124, in __new__
    bus = cls._new_for_bus(address_or_type, mainloop=mainloop)
dbus.exceptions.DBusException: org.freedesktop.DBus.Error.FileNotFound: Failed to connect to socket /run/dbus/system_bus_socket: No such file or directory
make: *** [mk/chroot.mk:55: build/pop-os/22.04/chroot] Error 1
13r0ck commented 1 year ago

@n3m0-22 See the fist comment https://github.com/pop-os/iso/pull/318#issue-1685826825. https://github.com/pop-os/repolib/pull/68 needs to be merged and released first. That is why that is failing

13r0ck commented 1 year ago

@n3m0-22 That was released, and this should be working now

n3m0-22 commented 1 year ago

The previous issue seems to be resolved by https://github.com/pop-os/repolib/pull/68. I am seeing a new issue now.

Unpacking ubuntu-mono (20.10-0ubuntu2) ...
dpkg: dependency problems prevent configuration of ubuntu-mono:
 ubuntu-mono depends on adwaita-icon-theme; however:
  Package adwaita-icon-theme is not configured yet.
 ubuntu-mono depends on humanity-icon-theme; however:
  Package humanity-icon-theme is not configured yet.

dpkg: error processing package ubuntu-mono (--configure):
 dependency problems - leaving unconfigured
Errors were encountered while processing:
 ubuntu-mono
E: Sub-process /usr/bin/dpkg returned an error code (1)
make: *** [mk/chroot.mk:55: build/pop-os/22.04/chroot] Error 100
13r0ck commented 1 year ago

@n3m0-22 are you adding metapackage-reorg to the STAGING_BRANCHES? That requires some other changes that I have in #321. For this just settings the STAGING_BRANCHES=master should be good enough for testing.

Please make sure that the ISO builds and functions as expected when not staging branches are added, and when some are added