search

pop-os / keyboard-configurator

Keyboard configuration UI
GNU General Public License v3.0
259 stars 45 forks source link

Feature request: make bonw14 and bonw15 LEDs configurable #206

Open leviport opened 12 months ago

leviport commented 12 months ago

This could be because my firmware/EC is in a pretty strange state right now, but while testing https://github.com/pop-os/keyboard-configurator/pull/204, I noticed that the LED tab on bonw14 is missing: Screenshot from 2023-07-12 18-41-13

This is not a regression on that PR, however. It is even present on version 1.3.6, which is what I currently have installed on my Bonobo.

ids1024 commented 12 months ago

This is expected behavior currently, since the on bonw14 this is a USB device not controlled through the EC. There's a special case for it:

https://github.com/pop-os/keyboard-configurator/blob/deb8384cac4cc9c716476b1bbcb08aebca87fce0/layouts.py#L530-L533

It would be nice to support this somehow. But I don't have one and don't know if/how that could be done.

leviport commented 12 months ago

Ah that's right, I had forgotten about that. I've changed the title to reflect that this is a feature request, rather than a bug.

ids1024 commented 12 months ago

Yeah, it's good to have an issue tracking it anyway.