search

pop-os / keyboard-configurator

Keyboard configuration UI
GNU General Public License v3.0
261 stars 45 forks source link

Add darp9 layout #209

Closed leviport closed 1 year ago

leviport commented 1 year ago

I'm not sure if this is all that's needed? Need to test with a darp9 on Monday.

leviport commented 1 year ago

Mic mute is working, but keyboard brightness cycle is not available in the picker, or showing up in the keymap. There are also a few other missing mappings in the keymap, but they are not regressions, and being tracked in https://github.com/pop-os/keyboard-configurator/issues/176

Screenshot from 2023-07-17 09-37-33

ids1024 commented 1 year ago

keyboard brightness cycle is not available in the picker

Ah, interesting. layouts.py generated layouts/keyboards/system76/15in_102/keymap.json with KBD_COLOR and without KBD_BKL. Because it is used elsewhere in laptops that have color backlights.

So if 15in_102 and has_color: false are correct here, that's an issue with how keymap.json is handled currently, but that should be fixed by https://github.com/pop-os/keyboard-configurator/pull/208. That PR is currently blocked by the fact it generates different led.json files for launch_heavy_1 (the LED layout in QMK is wrong currently, perhaps?). But if this helps with darp9, I could revert the those led.json files and add darp9 to that PR.

ids1024 commented 1 year ago

Added darp9 to https://github.com/pop-os/keyboard-configurator/pull/208, generated using layouts.py with the meta.json from this PR.

That should address some of the issues here.

leviport commented 1 year ago

Sounds good! I'll close this since it's superseded by #208