search

pop-os / keyboard-configurator

Keyboard configuration UI
GNU General Public License v3.0
261 stars 45 forks source link

chore: update to gtk-rs v0.18 #224

Closed decathorpe closed 7 months ago

decathorpe commented 8 months ago

The first commit in this PR ports keyboard-configurator to v0.18 of gtk-rs, which is apparently also going to be the last version of gtk-rs that will have GTK3 bindings. The second commit fixes all the clippy warnings that have been introduced in recent versions of Rust.

The first part was split off from https://github.com/pop-os/keyboard-configurator/pull/221 since gtk-rs v0.18 is not available on all targeted distributions yet.

I'm not in a hurry to get this landed, I'm just posting it as a separate PR since I already did the work and it might be useful for you in the future.

There were small API changes in gtk/glib v0.18 that required minor code changes. They are documented in the upstream release notes here: https://gtk-rs.org/blog/2023/08/28/new-release.html#replacement-of-glibcontinue--glibinhibit

ids1024 commented 8 months ago

Looks like Ubuntu Jammy (and Focal) has Rust 1.70.0 now. So I think this should be fine now?

decathorpe commented 8 months ago

Looks like jammy and focal have Rust 1.71.0 now (but only on x86_64 and i686, if I read this correctly: https://packages.ubuntu.com/search?keywords=rustc&searchon=names&exact=1&suite=all&section=all) - not sure if you care about the other architectures.

ids1024 commented 8 months ago

Oh, interesting that they're not packaging the same version on other architectures. But it looks like the versions they do have on focal and jammy for those architectures would already be too old, so this shouldn't be a problem.

decathorpe commented 7 months ago

Thanks for merging!