search

pop-os / launcher

Modular IPC-based desktop launcher service
Mozilla Public License 2.0
228 stars 47 forks source link

Calculator, find plugins don't update results if characters are typed too quickly #13

Closed supermar1010 closed 3 years ago

supermar1010 commented 3 years ago

I had this weird issue today. I opened the launcher with the pop os shortcut, then proceeded to type =109-30. The result I got was 106. I tried it with a few different numbers, for example with a 40 it also gave me the wrong result. After tinkering around a bit, including using the normal numbers (not on the numblock), it worked for the 30 again, regardless if I typed the 30 on the numblock or not. It seems to onluy happen with numbers between 100 and 110(at least when I tested I could only reproduce it there, but I'm not sure if that's one condition).

OS: Arch Package source: aur/gnome-shell-extension-pop-shell-git Are there any other important information I can supply?

jacobgkau commented 3 years ago

It sounds like the 0 in 30 didn't get registered/the calculation didn't get updated after typing the last character. I haven't seen this with the calculator, but I've noticed something similar with find file searching where if I type quickly enough, I sometimes need to re-type the last character (or add a character and remove it) for the search to find what I'm looking for.

mmstick commented 3 years ago

The launcher interrupts were not updating the search query, so after an interrupt was handled it was using an older search query.