search

pop-os / launcher

Modular IPC-based desktop launcher service
Mozilla Public License 2.0
232 stars 48 forks source link

Scrollable find results #131

Open dakontiva opened 2 years ago

dakontiva commented 2 years ago

I often use the find command to locate documents and it works great, but sometimes the file I am looking for is not in the 8 results that the launcher shows. However, if I run fdfind <filename> in a terminal I can see the result in the next 10 items. It would be great if find command also displays all results in a scrollable fashion, similar to how the navigation results of the launcher work.

canadaduane commented 1 year ago

I believe the query results are currently hard-coded to either 8 or 100 here:

https://github.com/pop-os/launcher/blob/master/service/src/lib.rs#L584-L588

canadaduane commented 1 year ago

I suppose we could add last_query.starts_with('find ') to the condition. It feels a bit hacky though. I wonder if there is a better way?

Jeusto commented 1 year ago

Hi, are there any plans to make the number of search results configurable ? Or perhaps I could try doing a pull request ? I find the hard-coded value of 8 very limiting for some types of plugins and pretty much every other launcher that I know (Ulauncher, Alfred, Rofi, etc) allow scrolling through the results.

bramucas commented 4 months ago

Just moved to pop. I think making the number of results configurable (at least for "find") would be great :+1: