search

pop-os / launcher

Modular IPC-based desktop launcher service
Mozilla Public License 2.0
220 stars 42 forks source link

Justfile installs pop-launcher binary in wrong location #136

Open joaopfonseca opened 1 year ago

joaopfonseca commented 1 year ago

First of all, I would like to thank all contributors involved in this project. Both the Launcher and Shell are truly amazing tools and significantly improved my workflow.

The problem: I noticed on my laptop that before installing ZSH, I installed pop-shell and pop-launcher and they were working fine. However, once ZSH is installed, the launcher stops working. Is there anything I can do to make it work again? (This behavior was successfully replicated in a VM)

OS: Fedora 36

Thank you!

zoni commented 1 year ago

I have issues with pop-launcher on Fedora 36 as well. I suspect this is a $PATH issue, as the launcher (triggered via pop-shell) suddenly started displaying results as soon as I symlinked ~/.local/bin/pop-launcher as /usr/local/bin/pop-launcher (this is not a proper solution to the issue, just a workaround)

On my Arch Linux installs (exact same dotfiles, but everything else is obviously installed quite differently) it works without issue without needing this, though this might be because on Arch I installed via AUR which installs system-wide as well.

The reference to zsh here is quite curious. For what it's worth, I'm also using zsh and it is set as my user's default shell.

~/.local/bin/ is in my $PATH, which is set by my zshrc, which means it may not be in the environment for gnome-shell itself (as that starts sooner). Also, neither systemctl --user import-environment PATH nor dbus-update-activation-environment --systemd PATH make a difference

zoni commented 1 year ago

(Related: https://github.com/pop-os/launcher/issues/77)

joaopfonseca commented 1 year ago

Thank you so much! The workaround worked for me.

rivenirvana commented 1 year ago

My fix for this was that I had to ensure ~/.local/bin/ was added to PATH, sourced earlier in order and from a file other than .zshrc. So I just restored the .zprofile that I removed long ago (backup in /etc/skel) where it already had that specific setup for ~/.local/bin.

FelixTheWizard commented 1 year ago

I have issues with pop-launcher on Fedora 36 as well. I suspect this is a $PATH issue, as the launcher (triggered via pop-shell) suddenly started displaying results as soon as I symlinked ~/.local/bin/pop-launcher as /usr/local/bin/pop-launcher (this is not a proper solution to the issue, just a workaround)

On my Arch Linux installs (exact same dotfiles, but everything else is obviously installed quite differently) it works without issue without needing this, though this might be because on Arch I installed via AUR which installs system-wide as well.

The reference to zsh here is quite curious. For what it's worth, I'm also using zsh and it is set as my user's default shell.

~/.local/bin/ is in my $PATH, which is set by my zshrc, which means it may not be in the environment for gnome-shell itself (as that starts sooner). Also, neither systemctl --user import-environment PATH nor dbus-update-activation-environment --systemd PATH make a difference

Thanks! with the symlink everythig got to work properly

s373r commented 11 months ago

As another option (without symlinks), we can install to the expected right location using commands:

# Optional: if no build artifacts are present
just build-release

sudo just rootdir=/ install
#         ^^^^^^^^^
#         Install the launcher to /usr/bin/pop-launcher