search

pop-os / launcher

Modular IPC-based desktop launcher service
Mozilla Public License 2.0
232 stars 48 forks source link

fix: allow web plugin to xdg-open custom URI schemes #154 #155

Closed canadaduane closed 1 year ago

canadaduane commented 1 year ago

Prevents prefixing https:// to custom URI schemes

Fixes #154

canadaduane commented 1 year ago

The regex does not seem to not be working correctly.

Can you provide any detail on this? For example, does it prevent you from opening http or https URLs? It should continue to work for http and https, and of course also allow new schemes such as obsidian:.

Regarding Obsidian's registered mime-type and xdg-open specifically, I've documented that I cannot get it to work yet here due to a different issue.

mmstick commented 1 year ago

May just require tweaking the xdg_open function to set stdout and stderr to null

canadaduane commented 1 year ago

May just require tweaking the xdg_open function to set stdout and stderr to null

You're right! It works. I'll add this to the PR.