search

pop-os / launcher

Modular IPC-based desktop launcher service
Mozilla Public License 2.0
232 stars 48 forks source link

fix: deactivate cosmic plugin when not in a COSMIC session #170

Closed mmstick closed 1 year ago

mmstick commented 1 year ago

This change will ensure that the cosmic plugin is deactivated if the launcher is not in a COSMIC session. It checks if XDG_CURRENT_DESKTOP contains COSMIC to do so.

Fixes #169

jacobgkau commented 1 year ago

I haven't been able to recreate https://github.com/pop-os/launcher/issues/169 (tested in GNOME on Pop!_OS with COSMIC Epoch installed, Pop!_OS without COSMIC Epoch installed, as well as on Ubuntu since the reporter mentioned Apport.)

This fix doesn't cause any problems in GNOME, but it seems to prevent the launcher from showing or searching open windows on COSMIC Epoch. That would be a regression? (Even though we're not shipping COSMIC Epoch yet.)

hojjatabdollahi commented 1 year ago

as well as on Ubuntu since the reporter mentioned Apport.)

I'm on Pop. I had to mask the Apport service to get rid of the lag.

I just tested it again. It doesn't happen on Pop XOrg, but happens on Pop Wayland. I have been using Wayland for so long I forgot to mention it, my apologies.

mmstick commented 1 year ago

@jacobgkau What's your output for XDG_CURRENT_DESKTOP in COSMIC? It should be pop:COSMIC. Unless the launcher is running in an environment where this is not passed down to it.

mmstick commented 1 year ago

Also yeah I've been having this issue in the Wayland session of Pop.

wash2 commented 1 year ago

@jacobgkau I can also recreate the issue in COSMIC.