search

pop-os / launcher

Modular IPC-based desktop launcher service
Mozilla Public License 2.0
228 stars 47 forks source link

fix(calc): Update description from JS to Rust dependency #18

Closed friday closed 3 years ago

friday commented 3 years ago

You might want it to say something different though, but at least not Math.JS any longer :)

friday commented 3 years ago

Thank you for updating this description. This does not affect the functionality of the calculator plugin.

True. I wasn't sure if the commit message should have been chore or fix, it changes the displayed name users see after all.

jacobgkau commented 3 years ago

it changes the displayed name users see after all.

So it does... I see now that the plugin descriptions are used in their help entries.

Screenshot from 2021-09-13 13-21-50

Still looks fine to me. I could potentially see a user misinterpreting qalc as the prefix to type in the launcher, but none of the other help entries display prefixes (probably because some of them have multiple), and this seems like a logical place to mention the calculator's backend (MathJS was mentioned before.)