The first commit changes the cosmic-toplevel plugin to always parse the desktop entries and match by the parsed app_id (which can be different than the file name) and parsed StartupWMClass.
The latter fixes icons not showing up primarily for Xwayland apps, who use the wm-class for identification, but don't always use the app-id in place. Additionally this fixes a lot of electron apps, that don't handle the app-id correctly in general up until the very latest release.
The second commit introduces the same fallback icon we are using in the cosmic-toplevel and pop-shell plugins for apps lacking an icon to the desktop-entries plugin as well. In case this in controversial, as this icon might now show up in places, where previously no icon was shown, this commit can easily be dropped. In my opinion is improves consistency across the plugins.
The first commit changes the
cosmic-toplevelplugin to always parse the desktop entries and match by the parsedapp_id(which can be different than the file name) and parsedStartupWMClass.The latter fixes icons not showing up primarily for Xwayland apps, who use the wm-class for identification, but don't always use the app-id in place. Additionally this fixes a lot of electron apps, that don't handle the app-id correctly in general up until the very latest release.
The second commit introduces the same fallback icon we are using in the
cosmic-toplevelandpop-shellplugins for apps lacking an icon to thedesktop-entriesplugin as well. In case this in controversial, as this icon might now show up in places, where previously no icon was shown, this commit can easily be dropped. In my opinion is improves consistency across the plugins.