search

pop-os / launcher

Modular IPC-based desktop launcher service
Mozilla Public License 2.0
219 stars 42 forks source link

TopLevel search results always get displayed before other plugins, even if the match score is low #217

Open wiiznokes opened 1 month ago

wiiznokes commented 1 month ago

For the top_level and desktop entries plugins, a f64 between 0 and 1 will fit.

wiiznokes commented 1 month ago

I just saw that the service does it. But still, plugins should be able to have an impact on the final result. It's great that the service handle recent selections and stuff tho

wiiznokes commented 4 weeks ago

Ok so after looking the code a bit, the service actually make a pretty good job at sorting the SearchResult. Comparing the score directly have similar result. But the problem is in the plugin priority. The top_level entries will always be shown before the desktop entries, even if they score its 0.1 and the other 1. This problem is also present in the cosmic-launcher UI. The app will try to gather all plugin search result together, by sorting the Indice field. I'm not sure its a good idea, but mixing different plugin results might be confusing. But the current behavior is not acceptable

jacobgkau commented 1 week ago

TopLevel showing up first is intentional: https://github.com/pop-os/launcher/pull/213

One of the items in the regression testing checklist is Open windows are sorted above applications (e.g. "web browser").

wiiznokes commented 1 week ago

Sure, i know it is intentional, but its really not perfect. A little bonus for TopLevel result should be preferred imo.