search

pop-os / launcher

Modular IPC-based desktop launcher service
Mozilla Public License 2.0
219 stars 42 forks source link

Desktop entries update #219

Open wiiznokes opened 4 weeks ago

wiiznokes commented 4 weeks ago

I plan to start playing with the score now, for modifying to order of the result. I don't include it in this PR to keep things separate, but since the new matching function will match more things, currently, the search result are not as good as previously. see #217

wiiznokes commented 1 week ago

Yes, I think i understand why this is the case. The old impl use

let append = search_interest.starts_with(&*query)
                    || query
                        .split_ascii_whitespace()
                        .any(|query| search_interest.contains(&*query))
                    || strsim::jaro_winkler(&*query, &*search_interest) > 0.6;

for matching while the new only use strsim::jaro_winkler(&*query, &*search_interest) (in fde).

Having both 

search_interest.starts_with(&*query)
                    || query
                        .split_ascii_whitespace()
                        .any(|query| search_interest.contains(&*query))

seems redundant. I will add the contains condition and update you

jacobgkau commented 1 week ago

No rush, but just to make sure this isn't waiting on us again, I assume something will need to be done in this PR to bring https://github.com/pop-os/freedesktop-desktop-entry/pull/23 in? Not sure if the freedesktop-desktop-entry version needs to be bumped, but we at least need a new git commit hash to trigger a rebuild.

wiiznokes commented 1 week ago

I assume fde needs a new version

jacobgkau commented 4 days ago

@mmstick Can you make a crate release including https://github.com/pop-os/freedesktop-desktop-entry/pull/23 so we can bump the version used in this PR to fix that regression?

mmstick commented 4 days ago

Sure

mmstick commented 4 days ago

Released as 0.6.2