search

pop-os / launcher

Modular IPC-based desktop launcher service
Mozilla Public License 2.0
228 stars 47 forks source link

Calculator plugin should display error when qalc is not installed #30

Closed tyalie closed 2 years ago

tyalie commented 2 years ago

I observed this with the calculator, find, scripts, .... e.g. searching for = 5 + 7 results into the output 5 + 7 x = ? without any calculation happening.

I think the shell should also output stderr of the pop-launcher command, for easier debugging.

System Config pop-launcher commit: pop-os/launcher@5cea11573dbb9180b144ac7420c0e6fba46aaefd pop-shell commit: pop-os/shell@522030336565badc6fd6068bd5e38328996aa4bf Gnome-Shell 3.36.9

/etc/os-release

NAME="Ubuntu"
VERSION="20.04.3 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.3 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal

Pop-OS shell and launcher are compiled from scratch.

The aforementioned plugins are all present in the ~/.local/share/pop-launcher/plugins/ directory and their corresponding binaries start into the JSON pipeline mode using e.g. ./calc without problems.

mmstick commented 2 years ago

What version of pop-launcher?

tyalie commented 2 years ago

Sorry I was in a hurry. I've updated the initial post.

tyalie commented 2 years ago

Small update: I can't seem to use Enter to launch applications shown in the launcher. Pressing Enter will instead result into a launcher window that didn't freeze except for the result list. Typing in a new search term will do nothing.

But Enter still works with the currently open windows.

Maybe this is related?

mmstick commented 2 years ago

What logs do you get from journalctl -o cat -f /usr/bin/gnome-shell as you are launching, searching, and activating entries?

tyalie commented 2 years ago

There's nothing in the gnome-shell logs relevant for this problem here.

But I was able to move the rust tracer logs to an output file and I've received these debug logs when trying to use the calculator. pop-launcher.using-calc.log

tyalie commented 2 years ago

And here the log when searching through .desktop entries pressing enter on the Telegram entry, deleting the search and searching for Typora. Except the list will not update after the enter key (see Activate(32)) pop-launcher.using-desktop.log

mmstick commented 2 years ago

I don't see any issues in the logs for the launcher service. For what it's worth, I can't replicate the issue in Pop!_OS 21.10. The description sounds like an issue with the GNOME Shell code in pop-shell for 20.04 specifically. Unsure if this happens on Pop 20.04 at the moment.

tyalie commented 2 years ago

Oke. Debugging the calculator: You'll need to have the qalc package installed for it to run. After installation it works. I think the calc plugin shouldn't fail silently if the binary is missing.

EDIT: Terminal worked fine from beginning. I just didn't new the syntax. My bad

tyalie commented 2 years ago

Oke. Found the error behind the applications not launching. It's a pop-os shell issue. I'll open an issue there.

tyalie commented 2 years ago

Oke. find doesn't work due to missing fdfind. This would be at least logged to stderr. I would honestly recommend to display such things directly in the search window.

tyalie commented 2 years ago

Oke. scripts does work, but launcher should hide when script is entered, as otherwise you will end up with the i.e. "Do you really wanna logout" window with the launcher still on.