Inform user if qalc or fdfind isn't installed

pop-os / launcher

Modular IPC-based desktop launcher service

Mozilla Public License 2.0

228 stars 47 forks source link

Inform user if qalc or fdfind isn't installed #36

Closed mmstick closed 2 years ago

mmstick commented 2 years ago

If attempting to use the calc plugin without qalc installed, the search result will be a message stating that it isn't installed.
Does the same for the find plugin with fdfind

Closes #30

jacobgkau commented 2 years ago

This is working for qalc. For fdfind, I'm seeing app search results if I type find without it installed, and once I type a space, the results seem to get stuck:

https://user-images.githubusercontent.com/7199422/136296240-d6e6b2b9-550a-4480-9fd2-9fe523c0da5c.mp4

journalctl is showing pop_launcher_plugsin::find: failed to spawn fdfind process: No such file or directory. I don't see anything like that when I get the qalc command is not installed message.

mmstick commented 2 years ago

It was missing a "Finished" message. Fixed.

jacobgkau commented 2 years ago

This PR is touching the terminal plugin, was it supposed to include 6cdf2987a90a349cfece71603191bf44a69d641e? (Can we rebase now that https://github.com/pop-os/launcher/pull/34 is merged? I was checking because I didn't want that to get undone.)

mmstick commented 2 years ago

I can rebase

jacobgkau commented 2 years ago

I'm no longer getting the freeze, but not getting any message about fdfind not being installed:

Peek 2021-10-07 10-31

The qalc message is still working.

mmstick commented 2 years ago

Forgot to .await the sending of the message.

jacobgkau commented 2 years ago

Working now! Is there a reason we say qalc command is not installed for qalc but only fdfind is not installed for fdfind? From what I can tell, both are commands. (In Ubuntu, qalc is actually the name of the qalc package, where fdfind's package is actually fd-find.)

mmstick commented 2 years ago

I can fix the wording of the message.