pop-os / launcher

Modular IPC-based desktop launcher service
Mozilla Public License 2.0
228 stars 47 forks source link

Calculator plugin improvements #47

Closed mmstick closed 2 years ago

mmstick commented 2 years ago
jacobgkau commented 2 years ago
  • Also fixes calculator activations to fill with the value, and not an expression describing how the value is derived.

I see what you mean with the second example (=4/3 used to autofill with the word approx. at the beginning, but no longer does). With the first example, though, I now see an equation in the result where I didn't before:

Screenshot from 2021-10-20 14-51-34

Activating that result does correctly autofill 7.5, but then I have 7 + 1/2 left as the next result:

Screenshot from 2021-10-20 14-54-53

If I keep selecting results, I eventually end up with true (seems to happen for several non-whole, non-repeating results):

Screenshot from 2021-10-20 14-54-56 Screenshot from 2021-10-20 14-54-57 Screenshot from 2021-10-20 14-54-59

Is this expected? It's not necessarily a problem, it just doesn't seem entirely intentional.

mmstick commented 2 years ago

It can be fixed to split from the last occurrence instead of the first for inputs like that.

titojankowski commented 2 years ago

Woohoo -- works great! Just installed the latest update through the Pop Shop and have this new functionality.