search

pop-os / launcher

Modular IPC-based desktop launcher service
Mozilla Public License 2.0
228 stars 47 forks source link

Launcher: searching for "keyboard configurator" #62

Open titojankowski opened 2 years ago

titojankowski commented 2 years ago

(1) Issue/Bug Description: Searching for "keyboard configurator" in the Launcher returns "Keyboard Layout" as the top search result

  1. This isn't the System76 Keyboard Configurator
  2. (Also, launching this "Keyboard Layout" appears to do nothing)

(2) Steps to reproduce (if you know):

  1. Start Launcher
  2. Enter "keyboard configurator"
  3. System76 Keyboard Configurator is the third result

(3) Expected behavior: I'd expect System76 Keyboard Configurator to be the top result

(4) Distribution (run cat /etc/os-release): NAME="Pop!_OS" VERSION="21.04" ID=pop ID_LIKE="ubuntu debian" PRETTY_NAME="Pop!_OS 21.04" VERSION_ID="21.04" HOME_URL="https://pop.system76.com" SUPPORT_URL="https://support.system76.com" BUG_REPORT_URL="https://github.com/pop-os/pop/issues" PRIVACY_POLICY_URL="https://system76.com/privacy" VERSION_CODENAME=hirsute UBUNTU_CODENAME=hirsute LOGO=distributor-logo-pop-os

(9) Other Installed/Enabled Extensions: Tweaks

(10) Other Notes: Sounds similar to issues like https://github.com/pop-os/shell/issues/979 and https://github.com/pop-os/shell/pull/753

jacobgkau commented 2 years ago

Current results:

Screenshot from 2021-11-12 10-01-29

Seems like the launcher needs to prioritize partial title matches over other metadata matches.

(Also, launching this "Keyboard Layout" appears to do nothing)

That .desktop file belongs to gkbd-capplet, which is being installed as a recommends of gnome-shell. (The app requires a layout to be passed in as an option when launching, but the .desktop file does not include a layout.) This entry does have NoDisplay=true set, but we ignore NoDisplay=true because it also has OnlyShowIn=GNOME (incorrect behavior IMO, but being used intentionally for GNOME Control Center currently), so this probably just needs another PR like https://github.com/pop-os/launcher/pull/45 to hide it (or that behavior flipped around/corrected to manually show G-C-C items and respect NoDisplay better.)