pop-os / libcosmic

WIP library for COSMIC applications
https://pop-os.github.io/libcosmic/cosmic/
Mozilla Public License 2.0
373 stars 32 forks source link

Certain theme colors are inconsistent/don't exist across devices (divider colors specifically) #370

Closed ryanabx closed 3 months ago

ryanabx commented 3 months ago

I noticed while working on https://github.com/pop-os/cosmic-applets/pull/317 that the dividers don't have a noticeable color on my amd laptop

This is my device with an intel i5 8250u: screenshot-2024-04-01-03-05-48

This is my device with an amd r9 6900hs and an amd radeon rx 6700s dGPU: screenshot-2024-04-01-03-04-28

git-f0x commented 3 months ago

I did notice that the dividers disappeared at one point for me, but wasn't sure if it was intended (AMD graphics; and very old Intel graphics on a different system (might be software rendering for the latter)).

edfloreshz commented 3 months ago

I can reproduce this on 2 AMD machines.

ryanabx commented 3 months ago

I did notice that the dividers disappeared at one point for me, but wasn't sure if it was intended (AMD graphics; and very old Intel graphics on a different system (might be software rendering for the latter)).

Cosmic-comp iirc doesn't support software rendering yet

git-f0x commented 3 months ago

That system doesn't support Vulkan or OpenGL 3, and I'm not sure if OpenGL 2 is supported by cosmic-comp (cosmic-term uses tiny-skia on that system), but idk. Not that it matters much on such an old system.

Drakulix commented 3 months ago

That system doesn't support Vulkan or OpenGL 3, and I'm not sure if OpenGL 2 is supported by cosmic-comp (cosmic-term uses tiny-skia on that system), but idk. Not that it matters much on such an old system.

Cosmic-comp can use OpenGL ES 2.0, if it has to.

ryanabx commented 3 months ago

I have some old screenshots from February showing that the colors were correct back then

WatchMkr commented 3 months ago

Perhaps related: pop-up outlines do not render correctly on some GPUs.

Image

ryanabx commented 3 months ago

Looks like the colors are present, they just match the background color (in the photo, you can make out the border around the images in the multi-window pop-up)

screenshot-2024-04-16-05-38-58

Given that this is GPU dependent, I suppose it's supposed to be rendering a different color, and the color is probably correct in-code?

git-f0x commented 3 months ago

I don't believe this was the case before, but the dividers are now visible for me on Light theme in applets and Store.

ryanabx commented 3 months ago

That's not the case for me, but I'll see if it is after building for today.

jackpot51 commented 3 months ago

We had a bug with theme derivation causing dividers to take on the background color. That is fixed but you must change the theme in an up to date settings app before it will take effect.

git-f0x commented 3 months ago

Oh, now that I changed "Application or window background" in Dark theme it seems the dividers are fully fixed on my end. And now I see that every 3rd and 6th window in the multiple window popup slightly clips outside the border (don't know beyond 6 since overflow isn't implemented). But not related to this issue. screenshot-2024-04-19-19-39-32

ryanabx commented 3 months ago

The colors are fixed for me too! Closing this issue