search

pop-os / libcosmic

WIP library for COSMIC applications
https://pop-os.github.io/libcosmic/cosmic/
Mozilla Public License 2.0
431 stars 42 forks source link

All COSMIC app windows should have a small neutral border and drop shadows #421

Open maria-komarova opened 5 months ago

maria-komarova commented 5 months ago

COSMIC app windows should have a small 1px border (@bg_divider color) inside each window area and a drop shadow: @shade_color which is defined as rgba (0, 0, 0, 0.32) for Dark mode, and rgba (0, 0, 0, 0.08) for Light mode.

Same borders and drop shadows should be applied to dialogs, all menu types and stand-alone notifications (notifications that pop up on the screen and disappear after delay, not the notification cards inside Notification center applet).

Drakulix commented 5 months ago

This is not a cosmic-comp issue, as it doesn't draw these types of decorations, instead the apps do. This is a libcosmic issue.

TheESN commented 5 months ago

This is not a cosmic-comp issue, as it doesn't draw these types of decorations, instead the apps do. This is a libcosmic issue.

What about applications with server side decorations?

maria-komarova commented 5 months ago

I'd include them as well unless they have some other styling.

git-f0x commented 5 months ago

Would this also apply to dialogs, modals and maybe applet popups?

maria-komarova commented 5 months ago

Ah, right, it should - dialogs, all menu types and stand-alone notifications. I wonder if we need a separate issue for this.

PoisonFrog commented 4 months ago

I'd include them as well unless they have some other styling.

It would be nice if the styling was consistent across libcosmic, libadwaita, GTK and QT. It would not look good if each toolkit/library had its own borders and shadows. In other desktops you usually only have this problem with apps like Steam, but QT and GTK usually have the same borders and shadows.

mmstick commented 4 months ago

@PoisonFrog It's not technically feasible to have precise styling across toolkits, as that requires fundamentally altering how those toolkits theme and render their widgets. We can only provide a best effort based on the theming capabilities those toolkits make configurable to the OS.

PoisonFrog commented 4 months ago

@PoisonFrog It's not technically feasible to have precise styling across toolkits, as that requires fundamentally altering how those toolkits theme and render their widgets. We can only provide a best effort based on the theming capabilities those toolkits make configurable to the OS.

I understand, but I was talking about borders and shadows only. Borders and shadows are quite consistent across toolkits in KDE and XFCE. I understand that the look and feel of the apps in general will not be consistent across toolkits.

TheESN commented 4 months ago

@PoisonFrog It's not technically feasible to have precise styling across toolkits, as that requires fundamentally altering how those toolkits theme and render their widgets. We can only provide a best effort based on the theming capabilities those toolkits make configurable to the OS.

I understand, but I was talking about borders and shadows only. Borders and shadows are quite consistent across toolkits in KDE and XFCE. I understand that the look and feel of the apps in general will not be consistent across toolkits.

This consistency is achieved by usage of Server Side Decorations. I think that applications that utilizes them will look consistent in COSMIC