Open hgaiser opened 3 months ago
If nothing else, we shouldn't override a file we can't parse.
Also in the meantime, cosmic is only doing this, if you enable the experimental "Apply this theme to GNOME apps" option.
If nothing else, we shouldn't override a file we can't parse.
Also in the meantime, cosmic is only doing this, if you enable the experimental "Apply this theme to GNOME apps" option.
Ah thanks, I can at least disable this behavior for now :)
By the way, this behavior still seems to happen when "Apply this theme to GNOME apps" was disabled.
As @hgaiser said this behaviour is happening after disabling also. Btw never enabled it. Their is something else. Cc: @mmstick
Everytime I log in, COSMIC overrides my entire
settings.json
file for VSCode. All the settings are gone and replaced with only a COSMIC theme. The intend ofcosmic-theme
is to only inject the theming part, but this line does not work for VSCodesettings.json
files.VSCode
settings.json
does not strictly follow the json syntax. It, for instance, also allows trailing comma's and comments. If this syntax is used,serde_json
produces an error. Since mysettings.json
file includes trailing comma's, COSMIC throws away the entire file because it fails to parse it.The issue with
serde_json
:Produces the error:
Or simply:
Produces:
I'm not sure if there is a crate that can parse this style of json correctly (see this issue).
Regardless, I'm not a fan of forcibly setting the theme for an application like VSCode. My suggestion would be to add a theme to the VSCode extension marketplace and direct users there, if they wish to use it.