Closed ids1024 closed 2 months ago
I guess the use of tokio in https://github.com/pop-os/libcosmic/pull/548/commits/fd0e54747976c383f02212a753a2b0bde06af6c5, although a clean solution, is problematic if the tokio
feature of libcosmic
isn't enabled...
With the changes here:
cosmic::process::spawn
and cosmic::desktop::spawn_desktop_exec
are now async functions.process
and desktop
features now depend on either smol
or tokio
features being enabled. But if we depend on zbus
, it will fail to compile anyway without one of those. Presumably cosmic apps should always enable one.tokio
feature is enabled, the futures will need to be called in the tokio executor, which should be like other things.These things seem reasonable.
This is needed for things like
xdg-desktop-portal
to get the app ID from a pid, in unsandboxed apps.A couple things still should be fixed here, then
cosmic-launcher
,cosmic-app-list
, andcosmic-app-library
will need to be updated to use this.