search

pop-os / linux

Pop!_OS fork of https://launchpad.net/ubuntu/+source/linux
Other
110 stars 14 forks source link

ALSA: hda - Improv 3.5mm hotplug on ROG strix B550 #170

Closed 13r0ck closed 2 years ago

13r0ck commented 2 years ago

When plugging of unplugging an audio jack on this motherbaord, sometimes the audio jacks would stop appearing to pipewire/pulseaudio. Interestingly cat-ing out the file /proc/asound/<card number>/codec#0, and or restarting pipewire fixes the issue temporarily.

This PR improves the current functionality by making hotplug with one 3.5mm jack work, it still breaks if hotplug is between multiple jacks though. @pop-os/quality-assurance please check with Eva+Tony if this is good enough for now to ship while I look into possible better solutions.

ids1024 commented 2 years ago

So by removing AZX_DCAPS_PM_RUNTIME, this would just cause some (fairly small) increase in power consumption, by not suspending the audio controller when not in use? That seems reasonable enough, though it applies to various systems that may not have any issue. I think only desktop systems, right?

13r0ck commented 2 years ago

Good point. I modified the commit to only effect systems with the same pci id. With that change I believe that this will only effect desktops, that is what the original commit and linked issue appear to suggest https://github.com/pop-os/linux/commit/de768ce45466f3009809719eb7b1f6f5277d9373

13r0ck commented 2 years ago

Force pushing for the release of 5.19 broke this PR, this is superseded by #171