search

pop-os / mouse-configurator

Configurator for HP 935 Creator Wireless Mouse
MIT License
8 stars 2 forks source link

Increasing the interface font in Tweaks doesn't play well with scaling Mouse diagram #11

Open maria-komarova opened 2 years ago

maria-komarova commented 2 years ago

We just stumbled upon another issue. When increasing the interface font in Tweaks, the SVG seems to scape up to 24 and then stops scaling resulting in labels overlapping the lines and each other. image It seems that scaling the svg along with the font and limiting the length of the buttons should take care of that but not sure if I'm missing something. What do you think @ids1024?

ids1024 commented 2 years ago

Huh, the image scaling but only up to a point isn't something I'd expect...

Limiting the length of buttons is easy if just using a set number of characters is suitable. At least. Let's see if scaling the svg works. I've already put work into making sure it could render at different scales and still have labels in the right positions. I still had issues trying to do it dynamically (as the window resized) though... basing it on font size may be doable.

maria-komarova commented 2 years ago

Setting the number of characters might be doable, the difficulty is the typefaces have various character widths and people can change typefaces. But we can try to create some sort of cushion and hope people won't choose very wide typefaces. I wonder if it would be enough to have the character limit to cover the scaling. Could we still run into the same overlapping issue as here when we increase font size if we set character limit to 20, for example.

ids1024 commented 2 years ago

Come to think of it, I wonder exactly what the definition of a "character" in gtk's max-width-chars is. With unicode, that becomes somewhat complicated...