search

pop-os / nvidia-graphics-drivers

Pop!_OS NVIDIA Graphics Drivers
141 stars 8 forks source link

470.57.02 #114

Closed leviport closed 3 years ago

leviport commented 3 years ago

https://www.nvidia.com/Download/driverResults.aspx/177145/en-us

cybik commented 3 years ago

Test Writeup

Issue

Using the latest 470.57.02 drivers, 2 out of 3 of my monitors exhibit a strange backlight behaviour where the backlight level seems to wave, essentially causing sort of a light flickering that becomes bothersome within a minute.

Hardware configuration

Software configuration

Behaviour tested on

Kernels tested

Miscelaneous details

jacobgkau commented 3 years ago

@cybik Can you please open the NVIDIA X Server Settings app, navigate to X Server Display Configuration -> Advanced, and enable the Force Full Composition Pipeline setting, then click Apply? I believe @bflanagin found that would stop the display flickering on G-Sync/FreeSync displays.

cybik commented 3 years ago

Damn. It does.

Still doesn't explain why it broke in the upgrade but I'll take it.

cybik commented 3 years ago

Profiles still missing in the latest libnvidia-common-470 package. Something's odd af.

leviport commented 3 years ago

Yeah I'm seeing that too. Interestingly, if I install the 470.57.02 driver in Ubuntu 21.04, the profiles are added correctly. I'm currently investigating what the differences might be between this package and Ubuntu's.

mmstick commented 3 years ago

I have used Meld to sync our debian packaging with Ubuntu's, preserving our modeset and xorg configuration changes. It added a few libs that weren't getting included, though I didn't see any changes specific to those profiles.

cybik commented 3 years ago

@mmstick still the common package is missing the magic files.

bflanagin commented 3 years ago

Looking at previous libnvidia-common deb files the last version that contained the files in question is a3ca7f3 (latest 465 version) but wasn't in c9385e3

mmstick commented 3 years ago

The files are definitely there when I build locally with sbuild.

cybik commented 3 years ago

I am obviously talking out of my proverbial backside, but either

I've little experience with debian packaging, but these would be my first impressions.

For the record, I've been installing the updates to verify, but I have copied the files manually from the extracted 470.latest .run file.

mmstick commented 3 years ago

sbuild is what the build servers use for packaging, and they create pristine chroots with no access to the network for building packages inside, and any changes made in these chroots are of course file system overlays that are discarded after one use.

mmstick commented 3 years ago

I'm wondering if Launchpad would have the same issue. We could merge to master and then check if the staging packages in the proposed PPA have the missing files. In general, debian packaging would error if those files listed in the .install file were missing when it was packaging.

ids1024 commented 3 years ago

Looking at the files manually:

http://apt.pop-os.org/staging/470.57.02/pool/hirsute/nvidia-graphics-drivers/nvidia-graphics-drivers-470_470.57.02-1pop0~1626951027~21.04~6df8618.tar.xz http://apt.pop-os.org/staging/470.57.02/pool/hirsute/nvidia-graphics-drivers/libnvidia-common-470_470.57.02-1pop0~1626951027~21.04~6df8618_all.deb

The source archive, and manual builds from it, seems fine. The .deb is missing the files according to dpkg -c.

leviport commented 3 years ago

So if I'm understanding correctly, the libnvidia-common-470 package is what is supposed to copy those files upon install, right? I'm not sure if this is significant, but if I apt download libnvidia-common-470 on both Pop 21.04 and Ubuntu 21.04, then dpkg -I the .deb file that downloads, this is the difference in output I get between Pop and Ubuntu. The size difference between the two is the main thing I thought was suspicious. 2021-07-22_10-34

I'm ok with building it in proposed on Launchpad if we're out of leads, but I think libnvidia-common-470 might be worth digging into.

edit: I should refresh before I post so I don't just repeat what others have already posted :disappointed:

leviport commented 3 years ago

@mmstick feel free to merge if you want to try building on Launchpad. I'd add an approval, but it's my PR. Just no releasing until we know those files are being added correctly, of course.

mmstick commented 3 years ago

Ping me if it's confirmed we have it working. Else I'll roll back and re-open a PR.

leviport commented 3 years ago

So far I'm seeing the magic files being added where they're supposed to be on my machine. Now we're investigating some possible weirdness with switchable graphics machines. It's probably nothing, but we want to be make sure.

bflanagin commented 3 years ago

When switching to Hybrid from Nvidia I'm being thrown back into Integrated mode.

From journalctl:

Jul 22 11:33:29 flanagins-gazelle systemd-udevd[505]: nvidia: Process '/sbin/modprobe nvidia-modeset' failed with exit code 1.
Jul 22 11:33:29 flanagins-gazelle kernel: nvidia-nvlink: Unregistered the Nvlink Core, major device number 511
Jul 22 11:33:29 flanagins-gazelle kernel: nvidia: probe of 0000:01:00.0 failed with error -1
Jul 22 11:33:29 flanagins-gazelle kernel: nvidia 0000:01:00.0: vgaarb: changed VGA decodes: olddecodes=none,decodes=none:owns=none
Jul 22 11:33:29 flanagins-gazelle kernel: nvidia 0000:01:00.0: can't change power state from D3cold to D0 (config space inaccessible)
Jul 22 11:33:29 flanagins-gazelle kernel: nvidia-nvlink: Nvlink Core is being initialized, major device number 511
Jul 22 11:33:29 flanagins-gazelle systemd[1]: nvidia-persistenced.service: Failed with result 'exit-code'.
mmstick commented 3 years ago

I'm getting nvidia 0000:01:00.0: can't change power state from D3cold to D0 (config space inaccessible)

mmstick commented 3 years ago

I believe we can fix this by disabling some of the newer udev rules in the Ubuntu packaging

mmstick commented 3 years ago

I've pushed a fix for this to master

bflanagin commented 3 years ago

D3cold issue is resolved on my end after the push. Everything is looking good, just want to do one or two more tests to be on the safe side.

bflanagin commented 3 years ago

Previous tests as well as our G-sync (Adaptive Sync) tests are all passing. The missing files are in place. I believe its ready for release.

cybik commented 3 years ago

User confirmation: the latest update packages for 470.57.02 contain the application profile files.