Closed 13r0ck closed 1 year ago
Should the 120M check be required if the system already has the DRM driver in initramfs?
Should the 120M check be required if the system already has the DRM driver in initramfs?
In that case, this won't do anything anyway, it also checks for if the DRM is already added, and if so does nothing
Ooops, fixed my math
Looks like the new math is working correctly on my special oryp6:
[levi@levioryx:~]$ df -h /boot/efi
Filesystem Size Used Avail Use% Mounted on
/dev/nvme0n1p1 511M 396M 116M 78% /boot/efi
[levi@levioryx:~]$ ls /usr/share/initramfs-tools/modules.d/
s76-i915-initramfs.conf system76-acpi-dkms.conf system76-dkms.conf system76-io-dkms.conf
This should add the nvidia drivers to the initramfs for all systems that have the nvidia-driver-515 package installed, and have 120M free of ESP space
1) If this works, https://github.com/pop-os/system76-driver/pull/246 should be closed. Please check that this fixes the affected systems there, oryp6, oryp9, oryp10, mira-b1, and mega-r2 as well as general regression testing. 2) Please also test for a system with less than 120M of free esp, 3) If possible test for OS upgrades. On broken systems like mega-r2, when doing an OS upgrade does the plymouth upgrade screen also break like the plymouth decrypt screen, if so, does this fix that? (on ubuntu and pop)