jacobgkau
commented
3 years ago I've tested this (along with https://github.com/pop-os/default-settings/pull/104 / https://github.com/pop-os/default-settings/pull/105) on the following machines so far:
- serw12 (1660 Ti)
- thelio-b1.6 (2070 Ti)
- galp4 (Intel)
- addw2 (2070), Hybrid and NVIDIA modes
On the NVIDIA machines/in NVIDIA mode, while resuming is entirely successful most of the time (often with a brief freeze either at the lock screen or just after unlocking), I've had a handful of cases where some artifacting occurs (to clarify, the black/white static is part of the video, the issue is the miscolored UI elements and jumbled page elements):
Unlike the previous distortion (with layers.acceleration and no NVreg option), this artifacting does go away when the affected portion of the window is redrawn (switching tabs is a quick way to bring everything back to normal), and this is very occasional (to the point where it's difficult to reproduce.) Portions of the window being transparent with further page distortion (as shown in the first screenshot) has only happened twice, once on addw2 in NVIDIA mode and once on serw12. Portions of the window being red has happened a few more times.
After switching back to the stable versions of NVIDIA and Firefox, I almost immediately got text/icon distortion in GNOME Shell after suspend/resume:
So I think this NVreg change should ship, but I'm not sure Firefox's WebRender is ready unless we're ready to field questions/complaints about the occasional distortion. (As a reminder, serw12 does require either WebRender, layers.acceleration, or xrender; the default renderer with none of these enabled is unacceptably choppy on that machine.)
Hopefully this should help with the suspend/resume issues with WebRender. Requires testing to make sure it fixes the issue and doesn't cause others.
Related: pop-os/default-settings#104 and pop-os/default-settings#105.