pop-os / pipewire

Packaging fork
https://gitlab.freedesktop.org/pipewire/pipewire
Other
7 stars 3 forks source link

Pipewire 0.3.77 #57

Closed mmstick closed 11 months ago

mmstick commented 11 months ago

Closes #56

jacobgkau commented 11 months ago

This is working fine so far, but we need to fix the i386 build for it to not have issues installing on systems with 32-bit libraries (e.g. Steam).

mmstick commented 11 months ago

I've not successfully figured out how to get systemd to install on i386 with our sbuild CI script. May need a tweak to our systemd packaging. It seems to demand to install chrony even though systemd-timesyncd should satisfy the time-daemon dependency.

jacobgkau commented 11 months ago

systemd-timesyncd should satisfy the time-daemon dependency.

When we moved the Chrony dependency from pop-desktop to systemd (to fix time sync on Ubuntu installations after we made our systemd-timesyncd package do nothing), I think we went with a hard dependency on Chrony only for systemd due to an apt bug with or-dependencies at the time, looking back at https://github.com/pop-os/systemd/pull/33.

I am confused why this would be an issue now but not for https://github.com/pop-os/pipewire/pull/55 last month when the Chrony change was back in April.

mmstick commented 11 months ago

It's been a little over a month since our last pipewire update. I think this is the only package that has systemd as a dependency.

mmstick commented 11 months ago

I'll make a PR so that chrony's not required for i386.

jacobgkau commented 11 months ago

We're depending on Ubuntu's Chrony build, which doesn't have an i386 build, but what's confusing is that if Chrony missing for i386 was the issue, then Ubuntu would have had to drop the i386 build of it within the last month since https://github.com/pop-os/pipewire/pull/55. Otherwise, something else changed to break this.

mmstick commented 11 months ago

It's probably fine for Ubuntu because <time-daemon> is also provided by systemd-timesyncd and ntp.

mmstick commented 11 months ago

The systemd change worked. i386 is built now.

jacobgkau commented 11 months ago

Regression testing passed: