T590 thinkpad option to update 20N5S1H500 system firmware doesn't work

thunder1410 commented 4 years ago

Distribution (run cat /etc/os-release):

NAME="Pop!_OS" VERSION="19.10" ID=ubuntu ID_LIKE=debian PRETTY_NAME="Pop!_OS 19.10" VERSION_ID="19.10" HOME_URL="https://system76.com/pop" SUPPORT_URL="http://support.system76.com" BUG_REPORT_URL="https://github.com/pop-os/pop/issues" PRIVACY_POLICY_URL="https://system76.com/privacy" VERSION_CODENAME=eoan UBUNTU_CODENAME=eoan LOGO=distributor-logo-pop-os

Related Application and/or Package Version (run apt policy $PACKAGE NAME): Setting -> devices -> firmware

Issue/Bug Description: I have a Lenovo T590 thinkpad and with my pop OS install it detects some system firmware. The UEFI bios updates worked but I also have 20N5SH500 system firmware. This has version number 0.1.53 and it says it could be updated to 0.1.54. If I try to update this I get the following error message: error in fwupd client: calling Install method failed: "No supported devices found" I tried doing some updates through Windows (dual boot) but that didn't make the option disappear. I guess it detects something wrong?

Steps to reproduce (if you know): Go to setting -> devices -> firmware -> 20N5S1H500 system firmware update -> reboot and install get this error message: error in fwupd client: calling Install method failed: "No supported devices found"

Expected behavior: That the OS reboots and installs a system update.

Other Notes: Lenovo T590 laptop with UEFI dual boot between Pop OS 19.10 and Windows 10. UEFI device firmware updated successful.

EDIT: apparently under load (gaming Cities: skylines) the CPU sometimes has dips to 200MHz. So maybe the detection isn't wrong because in the patch notes says it brings performance fixes for linux.

EDIT2: I managed to get the bios update working from windows and the version number changed to the right number. I can conclude that the detection works right but the update failed. I updated directly to version 1.55 from windows.

ldartez commented 4 years ago

I'm getting the same thing on my Lenovo X1 Extreme Gen 2. any help or diagnostic help would be greatly appreciated!

Clintie-The-GIT commented 4 years ago

Thinkpad T580 similar issue. Detects firmware update > click install and reboot but system reboots without installing update.

kaungmyatlwin commented 4 years ago

Is this still on track? I am having this problem as well.

joshmcarthur commented 4 years ago

I'm also having this problem with a T480.

I notice that in the 0.1.19 changelog for UEFI Device Firmware, the notes for the release include:

*Update item in this release are applicable to Windows OS only

Perhaps there is something in the firmware that won't update on a non-Windows OS installation and therefore doesn't bump the firmware version?

Here's the full output of fwupdmgr get-updates, which looks to back the firmware upgrade UI:

UEFI Device Firmware has firmware updates:
Device ID:               [ device ID is here]
GUID:                    [ GUID is here ]
ID:                      com.lenovo.ThinkPadN24HT.firmware
Update Version:          0.1.19
Update Name:             ThinkPad T480 Embedded Controller Update Update
Update Summary:          Lenovo ThinkPad T480 Embedded Controller Firmware
Update Remote ID:        lvfs
Update Checksum:         SHA1(c1c8b69f621d86ccd95f1f10f1f1458d424b552a)
Update Location:         https://fwupd.org/downloads/898dfd12ce191e7c28d7a25e3d414abe4eb712fe-Lenovo-ThinkPad-T480-ECFirmware-1.19.cab
Update Description:      Lenovo ThinkPad T480 Embedded Controller Firmware 1.19

                         The computer will be restarted automatically after updating EC completely. Do NOT turn off your computer or remove the AC adaptor while update is in progress.

                         This stable release fixes the following issues:

                         *Update item in this release are applicable to Windows OS only

pop-os / pop

T590 thinkpad option to update 20N5S1H500 system firmware doesn't work #735