Placeholder icon on "Flashing Completed" page for theme other than Pop

ids1024 commented 4 years ago

The process-completed icon doesn't seem to be present in other themes.

TechnologyMan101 commented 4 years ago

Same with the normal USB icon too

mmstick commented 4 years ago

We could include them as gresources in case the system icons are missing.

ids1024 commented 3 years ago

I see three icons Popsicle relies on here:

This seems to be the standard for icon theming, to the extent that there is one: https://developer.gnome.org/icon-naming-spec

Looking at that, and at other themes:

drive-removable-media-usb is not standard, but drive-removable-media is. The spec seems to suggest the correct behavior is to fall back to the more general one.
dialog-error is standard, and should always be available.
application-x-cd-image is not standard, though some other mime types are. It also exists in the Humanity theme.
process-completed seems to only be in the Pop theme?

pop-os / popsicle