search

pop-os / popsicle

Multiple USB File Flasher
MIT License
636 stars 77 forks source link

Format better, remove unnecessary borrows, update dependencies #160

Closed benarmstead closed 2 years ago

benarmstead commented 3 years ago

Formats the rust better using cargo fmt and also updates dependencies using cargo update. Also removes some unnecessary borrows and uses better rust in some areas.

jacobgkau commented 3 years ago

This branch failed to build on the build server:

   Compiling popsicle v1.3.0 (/<<PKGBUILDDIR>>)
   Compiling loopdev v0.3.0
error: failed to run custom build command for `loopdev v0.3.0`

Caused by:
  process didn't exit successfully: `/<<PKGBUILDDIR>>/target/release/build/loopdev-2bb4022f30a22bf9/build-script-build` (exit code: 101)
  --- stderr
  thread 'main' panicked at 'Unable to find libclang: "couldn\'t find any valid shared libraries matching: [\'libclang.so\', \'libclang-*.so\', \'libclang.so.*\', \'libclang-*.so.*\'], set the `LIBCLANG_PATH` environment variable to a path where one of these files can be found (invalid: [])"', /<<PKGBUILDDIR>>/vendor/bindgen/src/lib.rs:2057:31
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...

I also had this issue on one machine locally, but not on another. Does libclang1 need to be added as a build-depends?

mmstick commented 3 years ago

Loopdev had an update which uses bindgen as a build-depends, and we need to have libclang-dev as a debian build depends for it to compile.

monomycelium commented 1 year ago

How can I get loopdev working on macos? See my issue #194 if you have any idea, thanks. I saw this: https://apple.stackexchange.com/a/243075, showing how hdiutil can act like losetup.